Re: Entering emojis

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> +DEFUN ("font-has-glyph-p", Ffont_has_glyph_p, Sfont_has_glyph_p, 2, 2, 0,
>
> Please call this font-has-char, since that's what it tests.

Sure.  The really logical name would be font-has-glyph-for-char-p, but
that's a mouthful.

>> +       doc:
>> +       /* Say whether FONT has a glyph for CHAR.  */)
>
> Not FONT, FONT-OBJECT.  They are different beasts.

Fixed.

> Some font backends have a has_char method, which should be used if
> available in preference to encode_char.  So I think a better
> implementation for this is to call font_has_char (in which case
> FONT-OBJECT could also be a font-entity, something that could be
> useful in some cases).

Yup.  This seems to make the check about 15% faster.  Now pushed to the
branch.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no