[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: `make-frame' makes taller frame than the specified height

From: Jan D.
Subject: Re: `make-frame' makes taller frame than the specified height
Date: Wed, 13 Jul 2005 11:08:40 +0200
User-agent: Mozilla Thunderbird 1.0 (X11/20041206)

Stefan Monnier wrote:

The inconsistency is that when creating a frame, Emacs adds the tool bar
height to the frame parameter (say you specified height 40, Emacs adds 3 =>
43).  This makes sense in that you can specify 40 lines and not have to care
about the tool bar height.  But the lines in the frame-parameters is now 43.

So the bug is that specifying 40 gives you a frame whose parameter says 43.
We should make sure the two match.  Either by never adding the 3, or by
subtracting it again when we query the frame's parameter.

Richard M. Stallman wrote:

I think it is correct for the specified size of an Emacs frame
to refer to the text-editing part of the frame, not including
the tool bar or menu bar or borders or whatever else.

So the fix would then be to make height when querying frame parameters mean height not including tool bar. I think this is a risky change, some lisp code depends on the current behaviour (frame-notice-user-settings among other things). I suggest saving this for after the release.

   Jan D.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]