[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: problems with face-spec-reset-face and set-face-attribute

From: Eli Zaretskii
Subject: Re: problems with face-spec-reset-face and set-face-attribute
Date: Mon, 18 Jul 2005 06:34:36 +0300

> From: "Drew Adams" <address@hidden>
> Date: Sun, 17 Jul 2005 20:15:35 -0700
> 2. The doc string of set-face-attribute does not agree with that of
>    internal-set-lisp-face-attribute, which does its work. The former
>    says that FRAME=nil means change on all frames, but does not
>    mention that it also changes the default. In fact, it says that t
>    does that (which it doesn't). The doc string of
>    `internal-set-lisp-face-attribute' seems correct.

I think you misunderstood the doc string and/or the code.  (If you
actually tried set-face-attribute, then perhaps your testing was
incorrect; otherwise, please try it.)

When the doc says FRAME nil changes the attribute on all frames, it
doesn't have to say it includes the default, since ``all'' means just
that: all, including old, existing frames, and new, as yet to be
created.  (Of course, I won't object to saying that explicitly,
although the doc string is already very-very long.)

If FRAME is t, then set-face-attribute _does_ set the attribute for
new frames.  If it doesn't for you, please post a complete test case
to reproduce that bug.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]