Re: problem with tumme.el

[Mathias Dahl]

Stefan Monnier <address@hidden> writes:

>> Bash has other startup files.
>
> Not when executed as /bin/sh AFAIK (in non-login shells at least).
> This is specifically by design for those kinds of reasons we're
> seeing here.

In this particular place we call the command like this:

  (if (not (= 0 (call-process shell-file-name nil nil nil
                              shell-command-switch command)))

Also, in this case we came up with a solution where the noclobber
setting was not important, the tool (jpegtran) has a -outfile
parameter that we can use instead of redirection with ">".

So, is it OK to fix this now?

We are talking about a change from this:

(defcustom tumme-cmd-rotate-original-options
  "%p -rotate %d -copy all \"%o\" > %t"
  "Format of command used to rotate original image.
Available options are %p which is replaced by
`tumme-cmd-rotate-original-program', %d which is replaced by the
number of (positive) degrees to rotate the image, normally 90 or
270 \(for 90 degrees right and left), %o which is replaced by the
original image file name and %t which is replaced by
`tumme-temp-image-file'."
  :type 'string
  :group 'tumme)


to this:

(defcustom tumme-cmd-rotate-original-options
  "%p -rotate %d -copy all -outfile %t \"%o\""
  "Format of command used to rotate original image.
Available options are %p which is replaced by
`tumme-cmd-rotate-original-program', %d which is replaced by the
number of (positive) degrees to rotate the image, normally 90 or
270 \(for 90 degrees right and left), %o which is replaced by the
original image file name and %t which is replaced by
`tumme-temp-image-file'."
  :type 'string
  :group 'tumme)

/Mathias