Re: GTK build: some menus in the menu bar stay highlighted

[Jan Djärv]

Jan Djärv skrev:

> I'd say this is a bug in QtCurve.  I can not find a way to undo that 
> effect from within Emacs.  Apart from the obvious, always update menus 
> deep.  But I don't think we want to do that just for one theme.  Not 
> that I think it would break anything, it would just make menu bar 
> updating a bit slower.

I found an easier way.  Can you try the attached patch?

Thanks,

        Jan D.

Index: src/gtkutil.c
*** src/gtkutil.c.~1.106.~      2007-04-22 20:23:08.000000000 +0200
--- src/gtkutil.c       2007-04-25 20:00:05.000000000 +0200
***************
*** 2192,2198 ****
                                        cl_data,
                                        &group);
  
!           if (item->contents)
              {
                GtkWidget *submenu = create_menus (item->contents,
                                                   f,
--- 2192,2198 ----
                                        cl_data,
                                        &group);
  
!           if (item->contents || menu_bar_p)
              {
                GtkWidget *submenu = create_menus (item->contents,
                                                   f,
***************
*** 2479,2486 ****
--- 2479,2490 ----
                                                   cl_data,
                                                   &group);
  
+           GtkWidget *submenu = create_menus (NULL, f,
+                                              select_cb, NULL, highlight_cb,
+                                              0, 0, 0, 0, cl_data, 0);
            gtk_widget_set_name (w, MENU_ITEM_NAME);
            gtk_menu_shell_insert (GTK_MENU_SHELL (menubar), w, pos);
+           gtk_menu_item_set_submenu (GTK_MENU_ITEM (w), submenu);
  
            g_list_free (*list);
            *list = iter = gtk_container_get_children (GTK_CONTAINER (menubar));