bug-commoncpp
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Test framework


From: Federico Montesino Pouzols
Subject: Re: Test framework
Date: Fri, 17 Jan 2003 11:57:15 +0100
User-agent: Mutt/1.4i

On Fri, Jan 03, 2003 at 10:46:08AM -0800, Chad Yates wrote:
> I would have to agree the cppunit tree was pretty organized.  I have no
> opinion on the naming for the test files, just as long as the word test is
> in there somewhere, and that they are consistent.  I've used <Class>Test for
> what I've done, but will gladly change to test_<class> if that is the
> direction we want to go. cppunit has a contrib directory, is that
> conceptually the same thing as common c++'s patches directory?
> 

        As far as I know there is no contrib nor patches dir in cc++.

> > A good guideline would probably be: one library header, one set of test
> > files, but this breaks down for thread.h and others, since it has about
> > 10 classes in there (which should be split up, IMHO).
> 
> I think some of the headers have become bogged down, and should be broken
> down.  I'm of the opinion that for most tests a single class will be
> exercised, and so should have it's own file where it makes sense (a unit).
> in the cases where your testing the way multiple classes interface that
> standard may have to be brushed aside as you'd be testing a composite.  on a
> side note, I am willing to re-org the persist.h, engine.cpp, persist.cpp,
> digest.h digest.cpp md5.cpp, and sha.cpp files to better break them down
> closer to the 1 class equals 1 each of .h/.cpp/.tcc (.tcc is for templates?)
> files as appropriate.  the timing would just need to be decided on so I
> don't cause trouble for a merge back into cvs (since the contents of the
> files would be exploded over multiple other files).  I'm sure other areas
> could also benefit also, but these are ones I've become the most familiar
> with.
> 
> Comments?
> 

        Yes, some headers could be partitioned, digest.h could be a
header that just includes md5.h, sha.h, etc, composing a kind of
digest subsistem. I think that whether one header should hold one or
more classes depends on the structure of the system. For instance, SHA
is implemented with several classes; I would see it very extreme to
make one header for each class.

> ,Chad
> 
> 
> 
> _______________________________________________
> Bug-commoncpp mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/bug-commoncpp




reply via email to

[Prev in Thread] Current Thread [Next in Thread]