bug-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: NSPathUtilities Patch - TOC


From: David Ayers
Subject: Re: NSPathUtilities Patch - TOC
Date: Tue, 20 Apr 2004 11:12:51 +0200
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113

Sheldon Gill wrote:

In order for reviewers to more easily digest the changes in my pathclean patch I've separated things into stages. Each stage does, to some
degree, depend on those previous. Can't be helped.

Thanks Sheldon,

I'll start with minor technical details so that we can get those out of the way.


--- ../core/base/Source/GNUmakefile.cvs 2004-01-19 16:11:55.000000000 +0800
+++ ../core/base/Source/GNUmakefile     2004-01-16 16:58:21.000000000 +0800
@@ -192,6 +192,7 @@
 NSObjCRuntime.m \
 NSObject.m \
 NSPage.m \
+NSPathUtilities.m \
 NSPipe.m \
 NSPort.m \
 NSPortCoder.m \
@@ -229,6 +230,13 @@
 NSMessagePortNameServer.m
 endif
+ifeq ($(GNUSTEP_TARGET_OS), mingw32)
+ADD_HEADERS += \
+Win32Support.h \
+Win32_Utilities.h

The only effect of adding these headers to ADD_HEADERS is that they will get installed (made public). Now scanning through the other patches, I don't see a header file that depends on this, only NSPathUtilities.m. So unless you have a good reason to make them public, I'd strongly suggest to not add these to ADD_HEADERS and keep them private.

+BASE_MFILES += \
+Win32Support.m \
+Win32_Utilities.m
+endif
+
 ifeq ($(WITH_FFI),libffi)
 GNU_MFILES += cifframe.m
 BASE_MFILES += GSFFIInvocation.m


------------------------------------------------------------------------

2004-04-04 Sheldon Gill <address@hidden>

* Source/NSPathUtilities.h: Changed NSDomainMask to enumeration
        Added NSDocumentDirectory key (from MacOS X)
        Modified NSSearchPathDirectory enumeration for better MacOS X 
compatibility
          and future expansion. Paves way for algorithm improvement.

        * Source/NSPathUtilities.m:  Minor cleanup and improvements
        now sets NETWORK and LOCAL root to compile time values on conf failure
        support for eliminating environment variables (can't over-ride conf)
        Improved error path checking and handling.
        Added support for TMPDIR environment variable

        * Source/Win32Support.h:  New file & header for Win32 implementation
        Primary module ensures other modules are properly initialised
        Single header for inclusion, rather than requiring multiple headers

2004-01-18 Sheldon Gill <address@hidden>

        * Headers/Foundation/NSPathUtilities.h: More directory search keys
        Added new GSFindNamedFile() API call.
        Deprecated and deleted GSSystemRootDirectory()
        Deprecated and deleted GSStandardPathPrefixes()

        * Source/NSPathUtilities.m: New implementation with conf file and other 
features
        NSUserName() now relies on uid rather than LOGNAME environment variable
        GSDefaultsRootForUser() now returns full path to database location
        GSFindNamedFile() new function to find a named file in paths
        Deprecated NSOpenStepRootDirectory() with trivial implementation

        * Source/NSUserDefaults.m:  Simplified to use new GSDefaultsRootForUser
        pathForUser() no longer creates Library directory. Done elsewhere 
anyway.
        
        * Source/NSBundle.m: Searches properly for frameworks in all path 
domains

        * Source/Win32_Utilities: New file & header for Win32 implementation
          Environment variable read functions
          Initial functions to read from the registry


Hmm, I was hoping the patches would match the ChangeLogs. But if this is the "combined" ChangeLog then Source/GNUmakefile seems to be missing.

Cheers,
David




reply via email to

[Prev in Thread] Current Thread [Next in Thread]