[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 00/16] my last hefty patch drop

From: Aharon Robbins
Subject: Re: [PATCH 00/16] my last hefty patch drop
Date: Sat, 13 Mar 2010 22:45:38 +0200

Hi All.

> Patches 1 to 9 are simple cleanups, .....
> .....  The dfa.c after this patch is
> suitable for merging into gawk.

Jim - Please signal me off list as to when I should pull this in.

> Patch 10 adds more UTF-8 test cases (and multibyte in general) to make
> sure nothing breaks.
> Patch 11 is the patch I already posted regarding the handling of case
> folding for MB_CUR_MAX.  Using it for gawk would break IGNORECASE.
> I still would like to include this patch because it fixes two very bad
> bugs with -i: a regex like foo\W is broken with -i, and -o/--color are
> broken with -i too.

It's not acceptable to just break IGNORECASE.

> One solution to make this patch palatable to gawk would be to add
> more "feature bits" to dfasyntax, that specify whether dfaexec can
> make some assumptions about the input.

I think this is the way to go. It sounds reasonable to me. I don't
mind adding in a few more bits.  Also, as I said in mail off-list
to Jim, the newline-as-sentinel is from the primordial dfa code;
it's not something I'm married to, so it can be changed eventually
if y'all ever get to it.  Thus relying on it to signal certain
behaviors is a bad idea: feature bits are better all around.

If the patches after 11 don't break anything in gawk that's fine with
me.  I'll trust Jim to do the reviewing.

Thanks to both of you,


reply via email to

[Prev in Thread] Current Thread [Next in Thread]