[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 00/16] my last hefty patch drop

From: Paolo Bonzini
Subject: Re: [PATCH 00/16] my last hefty patch drop
Date: Sun, 14 Mar 2010 10:48:22 +0100

>> Patch 11 is the patch I already posted regarding the handling of case
>> folding for MB_CUR_MAX.  Using it for gawk would break IGNORECASE.
>> I still would like to include this patch because it fixes two very bad
>> bugs with -i: a regex like foo\W is broken with -i, and -o/--color are
>> broken with -i too.
> It's not acceptable to just break IGNORECASE.

It's not like it's "unfixable". :-)  You would need to interpose a
function to lowercase the buffer before calling dfaexec.  But likely
I'll end up doing that in grep too, since the newline-as-sentinel
behavior can actually be used to do the conversion piecewise, so that
it doesn't have the slow almost-quadratic behavior of grep 2.5.4.

> If the patches after 11 don't break anything in gawk that's fine with
> me.

The patches after 11 are basically impossible to apply without 11.

But anyway I first have to reproduce Jim's failures.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]