[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch #7132] Small change to grep-2.6

From: Paolo Bonzini
Subject: Re: [patch #7132] Small change to grep-2.6
Date: Wed, 24 Mar 2010 18:05:09 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.3

On 03/24/2010 05:21 PM, Norihiro Tanaka wrote:
>  However, maybe we have
>  to provide instead a !MBS_SUPPORT version of mbtolower, and use it
>  unconditionally?
Hmm, We mayn't also need to convert a text into the lower case for
MB_CUR_MAX == 1, but I don't make sure that.

Yes, dfa.c takes care of that right now. But actually the entire conversion is useless now that we use upstream glibc and that one has RE_ICASE. I prefer to leave it in place for now, but once 2.6.x stabilizes it will go away.

>  diff5 is ok too, but I made some changes there.
>  Would you mind reviewing the patches I posted to the mailing list?
Ok. But I don't like cur_mb_len not to be modified with `const',
though it's always equal to 1 in !MBS_SUPPORT.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]