[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: dfa.c order of include problem
From: |
Paul Eggert |
Subject: |
Re: dfa.c order of include problem |
Date: |
Thu, 31 Jan 2013 13:07:03 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 01/31/13 10:39, address@hidden wrote:
> The problem is dfa.c that includes limits.h after regex.h is included.
> If you leave it as is you are then relying on all systems to have header
> files that guard against multiple includes.
There's already a fix for this in Gnulib: its regex.h
arranges to include limits.h before it undefs and redefines
RE_DUP_MAX.
That reminds me, have you had a chance to look at my patch to
sync Gawk's regex code from Gnulib? That would fix this
problem for Gawk. It'd also fix a recently discovered
buffer overrun in the Gawk regex code; see
<http://www.sourceware.org/ml/libc-alpha/2013-01/msg00967.html>.
I'll attach an updated version of that patch. After applying
the patch, run the command "./merge-gnulib".
gawk.txt
Description: Text document