[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: font-backend branch
From: |
Kenichi Handa |
Subject: |
Re: font-backend branch |
Date: |
Fri, 02 May 2008 19:55:49 +0900 |
User-agent: |
SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/23.0.60 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
In article <address@hidden>, Jason Rumney <address@hidden> writes:
> The new code seems to be making a poor choice of font for Latin-1
> characters, it is choosing a symbol font which does not contain the
> characters for me. This was triggering a bug that is also present in the
> trunk which caused the crash that Juanma experienced. The choice of font
> for other Latin characters is also not optimal, as the font used for
> ASCII contains most of these characters, but in the font-backend branch
> other fonts are chosen.
To understand why a correct font can't be used on Windows, I
must track the code of fontset by gdb, but at the moment, I
can't build Emacs correctly on Windows even with these gcc
and gmake:
C:\cygwin\home\handa\emacs-fb\nt>make --version
GNU Make 3.81
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying
conditions.
There is NO warranty; not even for MERCHANTABILITY or
FITNESS FOR A
PARTICULAR PURPOSE.
This program built for i386-pc-mingw32
C:\cygwin\home\handa\emacs-fb\nt>gcc --version
gcc (GCC) 3.4.5 (mingw special)
Copyright (C) 2004 Free Software Foundation, Inc.
This is free software; see the source for copying
conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.
> In addition to the bug mentioned above, I got another crash while
> displaying etc/HELLO which was caused by using s->face->font in
> w32font_draw. Changing it to use s->font works, but I have no idea what
> the difference is between these two, and why s->face->font would be NULL
> while s->font points to a valid font.
I found that I made a silly mistake when I modified
w32term.c. So, I've just installed the attached change.
But, anyway, w32font_draw should use s->font instead of
s->face->font because the latter may not be correct when a
text is shown with mouse-face.
---
Kenichi Handa
address@hidden
*** w32term.c.~1.285.2.1.~ 2008-04-30 10:45:07.000000000 +0900
--- w32term.c 2008-05-02 17:09:25.000000000 +0900
***************
*** 1900,1906 ****
x += g->pixel_width;
}
}
!
{
int boff = s->font->baseline_offset;
struct font *font = s->font;
--- 1900,1906 ----
x += g->pixel_width;
}
}
! else
{
int boff = s->font->baseline_offset;
struct font *font = s->font;
- Re: font-backend branch, (continued)
Re: font-backend branch, Glenn Morris, 2008/05/01
Re: font-backend branch,
Kenichi Handa <=
- Re: font-backend branch, Jason Rumney, 2008/05/02
- Re: font-backend branch, Jason Rumney, 2008/05/02
- Re: font-backend branch, Kenichi Handa, 2008/05/02
- Re: font-backend branch, Jason Rumney, 2008/05/02
- Re: font-backend branch, Kenichi Handa, 2008/05/03
- Re: font-backend branch, Stefan Monnier, 2008/05/03
- Re: font-backend branch, Kenichi Handa, 2008/05/04
- Re: font-backend branch, Jason Rumney, 2008/05/04
- Re: font-backend branch, Stefan Monnier, 2008/05/04
- Re: font-backend branch, Kenichi Handa, 2008/05/06