Re: [Gnash-commit] /srv/bzr/gnash/trunk r11136: migrated rtmp netstream and netconnect classes from rsavoye's local branch and fixed various test cases in misc-ming.all

[Benjamin Wolsey]

Am Dienstag, den 16.06.2009, 12:08 -0600 schrieb Ben Limmer:
> message:
>   migrated rtmp netstream and netconnect classes from rsavoye's local branch 
> and fixed various test cases in misc-ming.all
> removed:
>   libcore/asobj/NetConnection_as.cpp
>   libcore/asobj/NetConnection_as.h
>   libcore/asobj/NetStream_as.cpp
>   libcore/asobj/NetStream_as.h
> modified:

So did anyone run the testsuite? This commit is a disaster and
completely cocks up NetConnection. I carefully and extensively tested
this class, often putting comments in as well as adding tests in the
testsuite. Then Sandro carefully tested and designed more of the class,
especially the connection handlers, exactly so that RTMP could be added
easily. Now all the tests fail, the design is *much* worse,
documentation is ignored, and there are segfaults everywhere.

The problem is not primarily with the rtmp code - though I haven't
checked where all the segfaults are coming from - but rather the way
it's integrated into libcore, which has no regard for the way
actionscript works.

This change should be reverted. Integrating libnet should start again
using the original design. Even though they were designed by different
people, it is actually trivial to integrate libnet into the old design -
they were written with the same thing in mind, after all.

The code that handles remoting already should not be removed until the
new code is widely tested. There's no need to replace stable working
code in a stable branch until everyone has had a chance to test it.

Also, an unrelated change that Sandro recently made to NetStream was
removed by this commit. It was also tested, and now fails that test.

This is really no way to treat a stable branch.

The test failures are below:

FAIL: astests-v6-Runner: expected: "NetConnection.Connect.Failed"
obtained: NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:100]
FAIL: astests-v6-Runner: expected: "error" obtained: status
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:101]
FAIL: astests-v6-Runner: expected: "NetConnection.Connect.Success"
obtained: NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:108]
FAIL: astests-v6-Runner: expected: "NetConnection.Connect.Failed"
obtained: NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:122]
FAIL: astests-v6-Runner: expected: "error" obtained: status
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:123]
FAIL: astests-v6-Runner: expected:
"NetConnection.Connect.Closed,NetConnection.Connect.Failed" obtained:
NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:127]
FAIL: astests-v6-Runner: expected: "NetConnection.Connect.Failed"
obtained: NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:133]
FAIL: astests-v6-Runner: expected: "error" obtained: status
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:134]
FAIL: astests-v6-Runner: expected: "NetConnection.Connect.Failed"
obtained: NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:138]
FAIL: astests-v6-Runner: expected: "NetConnection.Connect.Success"
obtained: NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:162]
FAIL: astests-v6-Runner: expected: "NetConnection.Connect.Success"
obtained: NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:171]
FAIL: astests-v6-Runner: gprocessor returned an error while playing
'NetConnection-v6.swf'
FAIL: astests-v6-Runner: gprocessor returned an error while playing
'Video-v6.swf'
FAIL: astests-v6-Runner: gprocessor returned an error while playing
'rtmp-v6.swf'
FAIL: astests-v7-Runner: expected: "NetConnection.Connect.Failed"
obtained: NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:100]
FAIL: astests-v7-Runner: expected: "error" obtained: status
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:101]
FAIL: astests-v7-Runner: expected: "NetConnection.Connect.Success"
obtained: NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:108]
FAIL: astests-v7-Runner: expected: "NetConnection.Connect.Failed"
obtained: NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:122]
FAIL: astests-v7-Runner: expected: "error" obtained: status
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:123]
FAIL: astests-v7-Runner: expected:
"NetConnection.Connect.Closed,NetConnection.Connect.Failed" obtained:
NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:127]
FAIL: astests-v7-Runner: expected: "NetConnection.Connect.Failed"
obtained: NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:133]
FAIL: astests-v7-Runner: expected: "error" obtained: status
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:134]
FAIL: astests-v7-Runner: expected: "NetConnection.Connect.Failed"
obtained: NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:138]
FAIL: astests-v7-Runner: expected: "NetConnection.Connect.Success"
obtained: NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:145]
FAIL: astests-v7-Runner: expected: "NetConnection.Connect.Success"
obtained: NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:162]
FAIL: astests-v7-Runner: expected:
"NetConnection.Connect.Closed,NetConnection.Connect.Success" obtained:
NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:168]
FAIL: astests-v7-Runner: gprocessor returned an error while playing
'NetConnection-v7.swf'
FAIL: astests-v7-Runner: gprocessor returned an error while playing
'Video-v7.swf'
FAIL: astests-v7-Runner: gprocessor returned an error while playing
'rtmp-v7.swf'
FAIL: astests-v8-Runner: expected: "NetConnection.Connect.Failed"
obtained: NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:100]
FAIL: astests-v8-Runner: expected: "error" obtained: status
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:101]
FAIL: astests-v8-Runner: expected: "NetConnection.Connect.Success"
obtained: NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:108]
FAIL: astests-v8-Runner: expected: "NetConnection.Connect.Failed"
obtained: NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:122]
FAIL: astests-v8-Runner: expected: "error" obtained: status
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:123]
FAIL: astests-v8-Runner: expected:
"NetConnection.Connect.Closed,NetConnection.Connect.Failed" obtained:
NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:127]
FAIL: astests-v8-Runner: expected: "NetConnection.Connect.Failed"
obtained: NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:133]
FAIL: astests-v8-Runner: expected: "error" obtained: status
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:134]
FAIL: astests-v8-Runner: expected: "NetConnection.Connect.Failed"
obtained: NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:138]
FAIL: astests-v8-Runner: expected: "NetConnection.Connect.Success"
obtained: NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:145]
FAIL: astests-v8-Runner: expected: "NetConnection.Connect.Success"
obtained: NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:162]
FAIL: astests-v8-Runner: expected:
"NetConnection.Connect.Closed,NetConnection.Connect.Success" obtained:
NetConnection.Connect.Closed
[/home/benjamin/Downloads/gnash/trunk/testsuite/actionscript.all/NetConnection.as:168]
FAIL: astests-v8-Runner: gprocessor returned an error while playing
'NetConnection-v8.swf'
FAIL: astests-v8-Runner: gprocessor returned an error while playing
'Video-v8.swf'
FAIL: astests-v8-Runner: gprocessor returned an error while playing
'rtmp-v8.swf'
 --=[ testsuite/as3/classes.all ]=-- 
FAIL: NetStream_asv7.swf died prematurely (SIGABRT)
FAIL: NetConnection_asv7.swf died prematurely (SIGABRT)
FAIL: NetConnection_asv8.swf died prematurely (SIGABRT)
FAIL: NetStream_asv8.swf died prematurely (SIGABRT)
 --=[ testsuite/misc-ming.all ]=-- 
FAIL: NetStream-SquareTestRunner: stream3.time 3.937 > 4150
FAIL: remotingTestRunner: gprocessor returned an error while playing
'remoting.swf'
 --=[ testsuite/swfdec ]=-- 
FAIL: run_swfdec_testsuite_l:
loadSound-matrix-reset-7.swf:5e5c541abe826b82f9639d12a55afca2 crashed
gnash (stdout in loadSound-matrix-reset-7.swf.out, stderr in
loadSound-matrix-reset-7.swf.err)
FAIL: run_swfdec_testsuite_n:
netconnection.swf:691d140eb395ca4094119c24ee9028d5 crashed gnash (stdout
in netconnection.swf.out, stderr in netconnection.swf.err)
FAIL: run_swfdec_testsuite_n:
netstream-dimensions.swf:9624d196e558ec1b9b78698a6ef8a5ea crashed gnash
(stdout in netstream-dimensions.swf.out, stderr in
netstream-dimensions.swf.err)
FAIL: run_swfdec_testsuite_n:
netstream-onstatus-notfound.swf:a76b78d242368068b8368b41c45a4f7f crashed
gnash (stdout in netstream-onstatus-notfound.swf.out, stderr in
netstream-onstatus-notfound.swf.err)
FAIL: run_swfdec_testsuite_n:
netstream-onstatus.swf:09e7aa99a2a33db3fa07c23bdee72e02 crashed gnash
(stdout in netstream-onstatus.swf.out, stderr in
netstream-onstatus.swf.err)
FAIL: run_swfdec_testsuite_s:
system-onstatus-netstream.swf:7a5f9dd09337ef9cba8fe55fef9f54a2 crashed
gnash (stdout in system-onstatus-netstream.swf.out, stderr in
system-onstatus-netstream.swf.err)

Comment:
> +
> +/// Called on NetConnection.connect(null).
> +//
> +/// The status notification happens immediately, isConnected becomes true.

... but it's dropped anyway:
> +//     notifyStatus(CONNECT_SUCCESS);

bwy

--
Use Gnash, the GNU Flash Player!
http://www.gnu.org/software/gnash/

Benjamin Wolsey, Software Developer - http://benjaminwolsey.de

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil