Re: [Gnash-commit] /srv/bzr/gnash/trunk r11136: migrated rtmp netstream and netconnect classes from rsavoye's local branch and fixed various test cases in misc-ming.all

[Benjamin Wolsey]

Am Mittwoch, den 17.06.2009, 08:24 -0600 schrieb Rob Savoye:
> On 06/17/09 08:12, Benjamin Wolsey wrote:
> 
> > irrelevant. I am talking about the way the NetConnection_as object
> > interfaces with whatever network code is used. The NetConnection code
> > can be _and should be_ substantially the same as it was, regardless of
> > whether libnet / libamf is used or the current code and curl.
> 
>    Well, I'm not 100% sure exactly what code you mean here. I did change 
> substantially how the existing code worked internally. The lack of any 
> existing test cases beyond the minimal ones in actionscript.all makes it 
> difficult to test for breakage. 

It is a mistake to consider them minimal, as they test for AS
compatibility quite well, and as all the relevant ones now fail they are
clearly also quite effective.

> All the new test cases pass, and the old 
> code couldn't pass any of them, so I assumed it's fine. So I'd love to 
> know exactly what code you are referring too.
> 

I'm talking about where status notifications happen, threaded calls to
AS functions, queued connections etc. These are far from trivial, as
even slight changes break real cases.

>    I still have a very difficult time understanding why code that works 
> only with one web site, namely OpenStreetMap, is considered in better 
> shape than code that handles much more. I have even more difficulty 
> understanding why code with minimal test cases is also considered 
> "better" than code with thousands of tests.

Again, I'm not talking about this code at all, and never was. Whether
readAMF or libamf is better is not the issue. It is the integration that
is now worse. It doesn't matter if libamf is completely perfect at what
it does; as long as it gets the AS stuff wrong it is no use.

--
Free Flash, use Gnash
http://www.gnu.org/software/gnash/

Benjamin Wolsey, Software Developer - http://benjaminwolsey.de

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil