Re: [Gnash-commit] /srv/bzr/gnash/trunk r11136: migrated rtmp netstream and netconnect classes from rsavoye's local branch and fixed various test cases in misc-ming.all

[Rob Savoye]

On 06/17/09 08:39, Benjamin Wolsey wrote:

> It is a mistake to consider them minimal, as they test for AS
> compatibility quite well, and as all the relevant ones now fail they are
> clearly also quite effective.

  In the branch all the existing test cases pass. This is more of a 
migration problem than a code one. We'll back the checkin out for the 
time being till it passes all the test cases again, both existing ones 
and the new ones. The plan was not to migrate it till then anyway, 
including testing with OSM, which was the last bug to fix.

> I'm talking about where status notifications happen, threaded calls to
> AS functions, queued connections etc. These are far from trivial, as
> even slight changes break real cases.

  Right, I did drop much of that code, as I disliked it's "design" as 
too fragile. That said, the new code *did* pass all the existing AS 
tests, so didn't break anything.

        - rob -