[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnewsense-dev] Re: [gNewSense-users] possible error in gen-kernel build

From: Sam Geeraerts
Subject: [Gnewsense-dev] Re: [gNewSense-users] possible error in gen-kernel builder script
Date: Sat, 15 Aug 2009 16:11:31 +0200
User-agent: Thunderbird (X11/20090711)

Kemmey, Whitney W CIV NSWCDD, K54 schreef:
The gen-kernel builder script includes the following lines:

    # Changes so it'll compile without some modules
    for i in debian/d-i/modules/*; do
        sed -i 's/^\([[^ ?][^ ?]*\)$/\1 ?/' $i

Is the sed command correct?  I think this is meant to look for every line that contains 
no spaces or question marks and append " ?" to the end of the line.  My regular 
expression skills aren't great, but I think it should be:

        sed -i 's/^\([^ ?][^ ?]*\)$/\1 ?/' $i

(Removed the first square bracket.)  Without this change, I think it's expecting the first character to be 
"[", "^", " ", or "?", which I think is incorrect.

Can anyone clarify?

(Moving to -dev.)

You're probably right that the regular expression is wrong. Your correction seems logical, but don't know what the sed script is actually for. I suppose it's to ensure that every module in debian/d-i/modules/* has a question mark behind it. However, I haven't been able to figure out what that means and if that's necessary.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]