Re: [Gnu-arch-users] [BUG] tla 1.2.2rc1 doesn't accept {arch}/=partner-versions file.

[Aaron Bentley]

Matthieu Moy wrote:
> I have a \{arch}/=partner-versions file with its corresponding id. tla
> 1.2 accepted that without complaining, but 1.2.2rc1 does complain:
>
> $ ls \{arch}/=partner-versions
> {arch}/=partner-versions  
> $ ls \{arch}/.arch-ids/=partner-versions.id 
> {arch}/.arch-ids/=partner-versions.id  
> $ tla tree-lint                                                                                                             
> These explicit ids have no corresponding file:
>
> {arch}/.arch-ids/=partner-versions.id
>
> $ tla --version
> tla address@hidden/dists--jblack--1.1--patch-33(configs/release/tla-1.2.2rc1) 
> from regexps.com
>
> Copyright 2003 Tom Lord
>
> This is free software; see the source for copying conditions.
> There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
> PARTICULAR PURPOSE.
>
> Report bugs to address@hidden
>
> # automatically generated release id (by tla build-config)
> #
>
> address@hidden/dists--jblack--1.1--patch-33(configs/release/tla-1.2.2rc1)
>
> ./src   address@hidden/package-framework--devo--1.0--patch-5
> ./src/docs-hackerlab    address@hidden/docs-hackerlab--devo--1.0--base-0
> ./src/docs-tla  address@hidden/docs-tla--devo--1.0--patch-5
> ./src/hackerlab address@hidden/hackerlab--devo--1.0--patch-96
> ./src/tla       address@hidden/tla--devo--1.3--patch-39
> $ tla-1.2 tree-lint
> $ 
>
> Is this intentional?

Yes.  Files in {arch} have ids based on their names.  You can't 
explicitly tag them.  Older versions of tla used a less-exact test:
Is there a corresponding file for this explicit-id?

This test failed to take into account that the corresponding file might 
not be source.  As a result, if you had a precious foo, you could commit 
a  .arch-ids/foo.id.  But if you checked out a tree like that, it would 
fail a tree-lint.

So I changed the test to:
What id does this .id file produce?  Does that id appear in the source 
inventory?

You've got a case I didn't anticipate, but it's a legitimate lint failure.

 If so, the error message should be more explicit.

Err, how?  All I know is that the .id file is useless.   I don't know why.

Aaron
--
Aaron Bentley
Director of Technology
Panometrics, Inc.