|
From: | John Meinel |
Subject: | Re: [Gnu-arch-users] [BUG] mini patch for pfs-dav.c and libneon GNU TLS work |
Date: | Sat, 25 Sep 2004 23:59:54 -0500 |
User-agent: | Mozilla Thunderbird 0.8 (Windows/20040913) |
- answer->dav_port = 80; + if (!str_cmp(answer->dav_scheme, "http")) + answer->dav_port = 80; + else + answer->dav_port = 443;
Just a quick question. Shouldn't this be: if (!str_cmp (answer->dav_scheme, "https")) answer->dav_port = 443; else: answer->dav_port = 80;Meaning, default to 80, unless we are sure this should be 443. The way the patch was submitted states "default to 443" unless we know we should be on 80.
I don't know for sure. But I would say, given any port to pick as default, go with 80.
I don't know what strings would exist in dav_scheme, though, to really recommend a specific fix.
John =:->
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] | Current Thread | [Next in Thread] |