Re: [PATCH] gnu: Add di.

[Alex Kost]

John J Foerch (2016-07-04 06:47 +0300) wrote:

> John J Foerch <address@hidden> writes:
>
>> Leo Famulari <address@hidden> writes:
>>
>>> On Sat, Jul 02, 2016 at 03:13:52PM -0400, John J Foerch wrote:
>>>> * gnu/packages/admin.scm (di): New variable.
>>>
>>> Thanks!
>>>
>>>> +    (arguments
>>>> +     `(#:phases
>>>> +       (modify-phases %standard-phases
>>>> +         (delete 'configure)
>>>> +         (delete 'check)
>>>
>>> Did you try setting `#:test-target "test"` in the arguments? The
>>> Makefile has a test target.
>>>
>>
>> I didn't know about that.  I'll try it out.
>>
> A test relating to an included perl module Filesys::di fails.  I hadn't
> intended to include that module in the package, as all I'm interested in
> is the 'di' binary.  Given that, I would suggest that we bypass the
> tests.

As for me, I would also disable the tests.  All these handmade Makefiles
in all sub-directories are a nightmare.  I think trying to figure out
what is needed to run the tests doesn't worth it.

Also don't forget to add a copyright line for yourself in the beginning
of "admin.scm".

-- 
Alex