[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add di.
From: |
John J Foerch |
Subject: |
Re: [PATCH] gnu: Add di. |
Date: |
Mon, 04 Jul 2016 21:53:07 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Leo Famulari <address@hidden> writes:
> On Mon, Jul 04, 2016 at 11:18:50AM -0400, John J Foerch wrote:
>> * gnu/packages/admin.scm (di): New variable.
>
> A few final nitpicks before others make a decision about the test suite
> ;)
>
>> + (arguments
>> + `(#:phases
>> + (modify-phases %standard-phases
>> + (delete 'configure)
>> + (delete 'check)
>
> We prefer to use #:tests? #f instead of deleting the check phase.
>
>> + (add-before 'build 'setup-environment
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (setenv "CC" "gcc")
>> + (setenv "prefix" (assoc-ref outputs "out"))
>> + #t)))
>> + #:make-flags (list "-e")))
>
> I would like for '-e' to be expanded to '--environment-overrides'. It
> seems that Schemers abhor abbreviations.
>
> Sorry for not mentioning these before. I can do them myself when pushing
> if there are no other changes to be made.
Sounds good. Thanks.
--
John Foerch
- [PATCH] gnu: Add di., John J Foerch, 2016/07/02
- Re: [PATCH] gnu: Add di., Leo Famulari, 2016/07/03
- Re: [PATCH] gnu: Add di., John J Foerch, 2016/07/03
- Re: [PATCH] gnu: Add di., John J Foerch, 2016/07/03
- Re: [PATCH] gnu: Add di., Alex Kost, 2016/07/04
- Re: [PATCH] gnu: Add di., John J Foerch, 2016/07/04
- Re: [PATCH] gnu: Add di., Leo Famulari, 2016/07/04
- Re: [PATCH] gnu: Add di.,
John J Foerch <=
- Re: [PATCH] gnu: Add di., John J Foerch, 2016/07/07
- Re: [PATCH] gnu: Add di., Leo Famulari, 2016/07/07
- Re: [PATCH] gnu: Add di., Alex Kost, 2016/07/08
- Re: [PATCH] gnu: Add di., Leo Famulari, 2016/07/07
- Re: [PATCH] gnu: Add di., John J Foerch, 2016/07/08
- Re: [PATCH] gnu: Add di., Leo Famulari, 2016/07/04
- Re: [PATCH] gnu: Add di., John J Foerch, 2016/07/04