[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#33386] [PATCH 1/2] gnu: gajim: Add support for Guix packaged plugin
[bug#33386] [PATCH 1/2] gnu: gajim: Add support for Guix packaged plugins.
Thu, 15 Nov 2018 19:19:03 +0100
On Wed, 14 Nov 2018 20:55:52 +0100
Clément Lassieur <address@hidden> wrote:
>+ (add-after 'unpack 'add-plugin-dirs
>+ (lambda _
>+ (substitute* "gajim/common/configpaths.py"
> + (pythonpath (string-append
> + "$HOME/.guix-profile/lib/python"
> + ,(version-major+minor
> + (package-version python))
> + "/site-packages")))
Hmm, don't both of these hard-code one profile? I thought one can use
any number of profiles - and this patch could definitely pick from the
wrong one. Why isn't the PLUGINS_USER setting enough? Can't it be
provided via environment variables? (set by the profile)
Also, shouldn't PYTHONPATH already have been set by the profile? For me,
it is set (to ~/.guix-profile/lib/python3.6/site-packages) when I log in.
Description: OpenPGP digital signature
[bug#33386] Gajim plugins, Clément Lassieur, 2018/11/14