[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#33386] [PATCH 1/2] gnu: gajim: Add support for Guix packaged plugin
[bug#33386] [PATCH 1/2] gnu: gajim: Add support for Guix packaged plugins.
Fri, 16 Nov 2018 11:13:58 +0100
mu4e 1.0; emacs 26.1
Danny Milosavljevic <address@hidden> writes:
> Hi Clément,
> On Wed, 14 Nov 2018 20:55:52 +0100
> Clément Lassieur <address@hidden> wrote:
>>+ (add-after 'unpack 'add-plugin-dirs
>>+ (lambda _
>>+ (substitute* "gajim/common/configpaths.py"
>> + (pythonpath (string-append
>> + "$HOME/.guix-profile/lib/python"
>> + ,(version-major+minor
>> + (package-version python))
>> + "/site-packages")))
> Hmm, don't both of these hard-code one profile?
I don't understand what this means.
> I thought one can use any number of profiles - and this patch could
> definitely pick from the wrong one.
What do you mean? This patch just adds the Guix packaged plugins to the
list of plugin dirs.
> Why isn't the PLUGINS_USER setting enough?
Because it doens't know about Guix installed plugins. It doesn't look
in ~/.guix-profile/whatever. Only at /gnu/store/...-gajim/something and
> Can't it be provided via environment variables? (set by the profile)
Gajim doesn't seem to support customizing plugin dirs through
environment variables, which is why I edited its code.
> Also, shouldn't PYTHONPATH already have been set by the profile? For
> me, it is set (to ~/.guix-profile/lib/python3.6/site-packages) when I
> log in.
It shouldn't be in the profile if python isn't installed.
[bug#33386] Gajim plugins, Clément Lassieur, 2018/11/14