[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#33386] [PATCH 1/2] gnu: gajim: Add support for Guix packaged plugin
[bug#33386] [PATCH 1/2] gnu: gajim: Add support for Guix packaged plugins.
Mon, 19 Nov 2018 00:15:55 +0100
> I don't understand what this means.
> > I thought one can use any number of profiles - and this patch could
> > definitely pick from the wrong one.
> What do you mean? This patch just adds the Guix packaged plugins to the
> list of plugin dirs.
guix supports any number of profiles as one user, the ~/.guix-profile one is
the default, you can create and select profiles at will.
You can specify any profile you want using the option "-p" to "guix package" -
also, "guix environment" will create a custom profile.
However, your patch hardcodes ~/.guix-profile which is in general not what a
using "-p" would want. I agree that it makes sense to search for the plugins in
the current profile, but it's not clear to me that ~/.guix-profile is always
guaranteed to BE the current profile. Is it?
fontconfig already hardcodes ~/.guix-profile and "guix environment" has a
special flag to fake it, so maybe (probably?) it's OK to use it after all.
I hope someone else can chime in - but this is what immediately caught my
eye because what's the use of all these environment variables if one
hard-codes ~/.guix-profile anyway - could have hard-coded it in all packages,
> > Why isn't the PLUGINS_USER setting enough?
> Because it doens't know about Guix installed plugins. It doesn't look
> in ~/.guix-profile/whatever. Only at /gnu/store/...-gajim/something and
> > Can't it be provided via environment variables? (set by the profile)
> Gajim doesn't seem to support customizing plugin dirs through
> environment variables, which is why I edited its code.
In general that's OK.
> > Also, shouldn't PYTHONPATH already have been set by the profile? For
> > me, it is set (to ~/.guix-profile/lib/python3.6/site-packages) when I
> > log in.
> It shouldn't be in the profile if python isn't installed.
Oh, makes sense.
Description: OpenPGP digital signature
[bug#33386] Gajim plugins, Clément Lassieur, 2018/11/14