Re: gnats/295: Query problems with gnats/gnatsweb 4

[Lars Henriksen]

On Sun, Dec 09, 2001 at 11:14:45PM +0100, Milan Zamazal wrote:
> >>>>> "LH" == Lars Henriksen <address@hidden> writes:
> 
>     LH> Now I have had a go with gcc and this seems to work as
>     LH> expected. The compilation wasn't clean, though, and I had to
>     LH> fiddle with a couple of files. The compiler, gcc-3.01, is
>     LH> separately installed and I just ran configure with
>     LH> CC=/<path>/gcc. Is that sufficient?
> 
> I think so.
> 
> Could you please elaborate on the compilation problems?  I've already
> heard before that gcc generates some warnings on Alpha (resulting in
> compilation failure with -Werror), but couldn't get more information.

Here are the five problems and how I got around them.

1. Type conflict (this is not a -Werror failure):

  for d in gnats send-pr doc; do gmake -C $d all-gnats; done
  gmake[1]: Entering directory `/par/PdTools/gnats/osf5.1-4-gcc/gnats'
  /vol/pack/gcc.3.0.1/bin/gcc -c -I. -I../../gnats-4/gnats 
-I../../gnats-4/gnats/../include  -g -O2 -W -Wall -ansi -pedantic -Werror 
-Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings -Wno-format  
-DHAVE_CONFIG_H -DGNATSD_USER_ACCESS_FILE=\"/vol/gnats/gnatsd_user.access\" 
-DGNATSD_HOST_ACCESS_FILE=\"/vol/gnats/gnatsd_host.access\" 
-DDEFAULT_GNATS_SERVICE=\"support4\" 
-DGLOBAL_DB_LIST_FILE=\"/vol/gnats/databases\" -DGNATS_USER=\"nmpr\" 
../../gnats-4/gnats/edit.c
  In file included from ../../gnats-4/gnats/edit.c:21:
  ../../gnats-4/gnats/gnats.h:130: conflicting types for `basename'
  
/vol/pack/gcc.3.0.1/lib/gcc-lib/alphaev67-dec-osf5.1/3.0.1/include/string.h:172:
 previous declaration of `basename'
  gmake[1]: *** [edit.o] Error 1

I removed the declaration in gnats.h.

2. Cast warnings:

  ../../gnats-4/gnats/regex.c: In function `re_match_2':
  ../../gnats-4/gnats/regex.c:3766: warning: cast from pointer to integer of 
different size
  ../../gnats-4/gnats/regex.c:3766: warning: cast from pointer to integer of 
different size
  ../../gnats-4/gnats/regex.c:3772: warning: cast to pointer from integer of 
different size
  ../../gnats-4/gnats/regex.c:3772: warning: cast to pointer from integer of 
different size
  ../../gnats-4/gnats/regex.c:3919: warning: cast to pointer from integer of 
different size
  ../../gnats-4/gnats/regex.c:3919: warning: cast to pointer from integer of 
different size
  ../../gnats-4/gnats/regex.c:3972: warning: cast to pointer from integer of 
different size
  ../../gnats-4/gnats/regex.c:3972: warning: cast to pointer from integer of 
different size
  ../../gnats-4/gnats/regex.c:4078: warning: cast from pointer to integer of 
different size
  ../../gnats-4/gnats/regex.c:4078: warning: cast from pointer to integer of 
different size
  ../../gnats-4/gnats/regex.c:4111: warning: cast to pointer from integer of 
different size
  ../../gnats-4/gnats/regex.c:4111: warning: cast to pointer from integer of 
different size
  ../../gnats-4/gnats/regex.c:4124: warning: cast to pointer from integer of 
different size
  ../../gnats-4/gnats/regex.c:4124: warning: cast to pointer from integer of 
different size
  ../../gnats-4/gnats/regex.c:4292: warning: cast from pointer to integer of 
different size
  ../../gnats-4/gnats/regex.c:4292: warning: cast from pointer to integer of 
different size

These didn't stop the compilation so I left them.

3. Declaration of unsetenv:

  /vol/pack/gcc.3.0.1/bin/gcc -c -I. -I../../gnats-4/gnats 
-I../../gnats-4/gnats/../include  -g -O2 -W -Wall -ansi -pedantic -Werror 
-Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings -Wno-format  
-DHAVE_CONFIG_H -DGNATSD_USER_ACCESS_FILE=\"/vol/gnats/gnatsd_user.access\" 
-DGNATSD_HOST_ACCESS_FILE=\"/vol/gnats/gnatsd_host.access\" 
-DDEFAULT_GNATS_SERVICE=\"support4\" 
-DGLOBAL_DB_LIST_FILE=\"/vol/gnats/databases\" -DGNATS_USER=\"nmpr\" 
../../gnats-4/gnats/client.c
  cc1: warnings being treated as errors
  ../../gnats-4/gnats/client.c: In function `clientConnect':
  ../../gnats-4/gnats/client.c:488: warning: implicit declaration of function 
`unsetenv'
  gmake[1]: *** [client.o] Error 1

Configure picked unsetenv up as present. It is conditionally (#ifdef _BSD) 
declared
in <stdlib.h>. I declared it unconditionally in "gnats.h".

4. Type conflict in tolower() argument:

  /vol/pack/gcc.3.0.1/bin/gcc -c -I. -I../../gnats-4/gnats 
-I../../gnats-4/gnats/../include  -g -O2 -W -Wall -ansi -pedantic -Werror 
-Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings -Wno-format  
-DHAVE_CONFIG_H -DGNATSD_USER_ACCESS_FILE=\"/vol/gnats/gnatsd_user.access\" 
-DGNATSD_HOST_ACCESS_FILE=\"/vol/gnats/gnatsd_host.access\" 
-DDEFAULT_GNATS_SERVICE=\"support4\" 
-DGLOBAL_DB_LIST_FILE=\"/vol/gnats/databases\" -DGNATS_USER=\"nmpr\" 
../../gnats-4/gnats/gnatsd.c
  cc1: warnings being treated as errors
  ../../gnats-4/gnats/gnatsd.c: In function `match':
  ../../gnats-4/gnats/gnatsd.c:199: warning: subscript has type `char'
  ../../gnats-4/gnats/gnatsd.c:199: warning: subscript has type `char'
  gmake[1]: *** [gnatsd.o] Error 1

I inserted a cast to unsigned char.

5. Unconditionally declared variable conditionally used:

  /vol/pack/gcc.3.0.1/bin/gcc -c -I. -I../../gnats-4/gnats 
-I../../gnats-4/gnats/../include  -g -O2 -W -Wall -ansi -pedantic -Werror 
-Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings -Wno-format  
-DHAVE_CONFIG_H -DGNATSD_USER_ACCESS_FILE=\"/vol/gnats/gnatsd_user.access\" 
-DGNATSD_HOST_ACCESS_FILE=\"/vol/gnats/gnatsd_host.access\" 
-DDEFAULT_GNATS_SERVICE=\"support4\" 
-DGLOBAL_DB_LIST_FILE=\"/vol/gnats/databases\" -DGNATS_USER=\"nmpr\" 
../../gnats-4/gnats/gnats-pwconv.c
  cc1: warnings being treated as errors
  ../../gnats-4/gnats/gnats-pwconv.c: In function `encrypt_':
  ../../gnats-4/gnats/gnats-pwconv.c:122: warning: unused variable `salt'
  gmake[1]: *** [gnats-pwconv.o] Error 1

I made the declaration conditional.

Lars Henriksen