Re: gnats/295: Query problems with gnats/gnatsweb 4

[Milan Zamazal]

>>>>> "LH" == Lars Henriksen <address@hidden> writes:

    LH> 1. Type conflict (this is not a -Werror failure):

    LH>   for d in gnats send-pr doc; do gmake -C $d all-gnats; done
    LH>   gmake[1]: Entering directory `/par/PdTools/gnats/osf5.1-4-gcc/gnats'
    LH>   /vol/pack/gcc.3.0.1/bin/gcc -c -I. -I../../gnats-4/gnats 
-I../../gnats-4/gnats/../include  -g -O2 -W -Wall -ansi -pedantic -Werror 
-Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings -Wno-format  
-DHAVE_CONFIG_H -DGNATSD_USER_ACCESS_FILE=\"/vol/gnats/gnatsd_user.access\" 
-DGNATSD_HOST_ACCESS_FILE=\"/vol/gnats/gnatsd_host.access\" 
-DDEFAULT_GNATS_SERVICE=\"support4\" 
-DGLOBAL_DB_LIST_FILE=\"/vol/gnats/databases\" -DGNATS_USER=\"nmpr\" 
../../gnats-4/gnats/edit.c
    LH>   In file included from ../../gnats-4/gnats/edit.c:21:
    LH>   ../../gnats-4/gnats/gnats.h:130: conflicting types for `basename'
    LH>   
/vol/pack/gcc.3.0.1/lib/gcc-lib/alphaev67-dec-osf5.1/3.0.1/include/string.h:172:
 previous declaration of `basename'
    LH>   gmake[1]: *** [edit.o] Error 1

    LH> I removed the declaration in gnats.h.

Done in CVS as well.  The function is already declared in libiberty.h,
in a safer way.

    LH> 3. Declaration of unsetenv:

    LH>   /vol/pack/gcc.3.0.1/bin/gcc -c -I. -I../../gnats-4/gnats 
-I../../gnats-4/gnats/../include  -g -O2 -W -Wall -ansi -pedantic -Werror 
-Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings -Wno-format  
-DHAVE_CONFIG_H -DGNATSD_USER_ACCESS_FILE=\"/vol/gnats/gnatsd_user.access\" 
-DGNATSD_HOST_ACCESS_FILE=\"/vol/gnats/gnatsd_host.access\" 
-DDEFAULT_GNATS_SERVICE=\"support4\" 
-DGLOBAL_DB_LIST_FILE=\"/vol/gnats/databases\" -DGNATS_USER=\"nmpr\" 
../../gnats-4/gnats/client.c
    LH>   cc1: warnings being treated as errors
    LH>   ../../gnats-4/gnats/client.c: In function `clientConnect':
    LH>   ../../gnats-4/gnats/client.c:488: warning: implicit declaration of 
function `unsetenv'
    LH>   gmake[1]: *** [client.o] Error 1

    LH> Configure picked unsetenv up as present. It is conditionally (#ifdef 
_BSD) declared
    LH> in <stdlib.h>. I declared it unconditionally in "gnats.h".

I added an autoconf test for the declaration.

Thanks for the investigation.

Regards,

Milan Zamazal

-- 
http://www.zamazal.org