lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Autobeaming patch rev 2


From: Carl D. Sorensen
Subject: Autobeaming patch rev 2
Date: Thu, 21 Aug 2008 13:11:05 -0600

I've revisited my proposed patch on autobeaming.

The time signature for the autobeaming is now taken from
timeSignatureFraction instead of from measureLength and beatLength.  This
prevents the previous conversion of 12/16 to 6/8.

In order to deal with potential conflicts between autobeaming based on
beatLength and beatGrouping, I have established the following logic.

1) if beatGrouping is valid (meaning that the total number of beats in
beatGrouping times beatLength is equal to measureLength), then beatGrouping
is used for autobeaming.

2) if beatGrouping is invalid, then beatLength is used for autobeaming.

The effect of this is to keep all existing code that controls autobeaming by
beatLength working, because when beatLength is changed, beatGrouping becomes
invalid.

Obtaining the time signature from timeSignatureFraction resolves issue 511.

I've attached a file that shows how this works (it could become a regression
test), a diff of scm/auto-beams.scm, and a pdf of the output.

Is it OK to apply?

Carl

Attachment: auto-beam-2.patch
Description: auto-beam-2.patch

Attachment: beatGrouping-test.ly
Description: beatGrouping-test.ly

Attachment: beatGrouping-test.pdf
Description: beatGrouping-test.pdf


reply via email to

[Prev in Thread] Current Thread [Next in Thread]