[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] scm/define-markup-commands.scm: remove some unnecessary

From: David Kastrup
Subject: Re: [PATCH 1/2] scm/define-markup-commands.scm: remove some unnecessary lookups
Date: Sat, 21 Nov 2009 17:32:26 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux)

Carl Sorensen <address@hidden> writes:

> I still don't like the divergence between define-markup-command and
> define-internal-markup-command.

Agree.  I think define-internal-markup-command makes for more readable
code.  If we can consider define-internal-markup-command to be used
_only_ in the distributed Lilypond tree, we can change its behavior any
way we like.

> Perhaps we should move towards required the default properties list
> for all defined markup commands.

My personal preference would be to phase out all *-internal-* commands
completely.  One way to do this would be a keyword based approach,
something like

(define-markup-command (args as previous)
  :properties ((var1 . default) var2)
  "DOC string"

The DOC string likely does not need a keyword of its own since it will
not be the only expression in the body.

In that manner, defaulted properties and DOC string can be added on an
as-needed base.

David Kastrup

reply via email to

[Prev in Thread] Current Thread [Next in Thread]