[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] scm/define-markup-commands.scm: remove some unnecessary

From: Nicolas Sceaux
Subject: Re: [PATCH 1/2] scm/define-markup-commands.scm: remove some unnecessary lookups
Date: Sat, 21 Nov 2009 20:28:50 +0100

Le 21 nov. 2009 à 17:32, David Kastrup a écrit :

> Carl Sorensen <address@hidden> writes:
>> I still don't like the divergence between define-markup-command and
>> define-internal-markup-command.
> Agree.  I think define-internal-markup-command makes for more readable
> code.  If we can consider define-internal-markup-command to be used
> _only_ in the distributed Lilypond tree, we can change its behavior any
> way we like.
>> Perhaps we should move towards required the default properties list
>> for all defined markup commands.
> My personal preference would be to phase out all *-internal-* commands
> completely.  One way to do this would be a keyword based approach,
> something like

I explained why there are two commands, whereas there used to be a single
one in the past. It's not only because of documentation generation. They
actually do different things: look at ly/ and scm/markup.scm

I'd be insterested to see an implementation of a single
`define-markup-command' for builtin and user defined markups, where user
defined commands do not pollute the (lily) module, and still are available
across file includes. If you can come up with one, fine, I'm not opposed to
#:property or #:category keywords. But if that's not possible, then please
stop with this macro unification debate. IMHO it's just waisting time, for
this is not a problem that you're trying to solve, but at most a little 


PS: *please*, call things by there name, it's "builtin", not "internal".

reply via email to

[Prev in Thread] Current Thread [Next in Thread]