Re: Make tab-note-heads and fretboards use common code. (issue186268)

[Carl Sorensen]

On 1/30/10 11:44 AM, "address@hidden" <address@hidden> wrote:

> Hi Carl,
> 
> I've just tested this, and it breaks two regtests:
> 
> 1) dead-notes.ly
> 
> The \deadNote command inside a chord is ignored (i.e., the tabs appear
> as numbers rather than crosses).  Replacing \deadNote with \tweak also
> fails.

I saw this earlier, but my last regtest check didn't show it up.  I wonder
what I'm doing wrong with my regtest running.

I never fixed the deadNote error; when the regtest run came back clean I
forgot about it.

> 
> 2) tablature-harmonic.ly
> 
> The harmonic brackets have disappeared.  Weirdly, if you move the
> \harmonic command between the notes in the chord, both heads get
> harmonics.

I'll check it out.

> 
> Regards,
> Neil
> 
> 
> http://codereview.appspot.com/186268/diff/3011/3012
> File lily/context-scheme.cc (right):
> 
> http://codereview.appspot.com/186268/diff/3011/3012#newcode97
> lily/context-scheme.cc:97: " If @var{def} is given, and property value
> is SCM_EOL,"
> SCM_EOL will be unfamiliar to most users

Thanks, I'll fix it.

Carl