[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Rietveld review
From: |
Reinhold Kainhofer |
Subject: |
Re: Rietveld review |
Date: |
Tue, 4 May 2010 12:10:56 +0200 |
User-agent: |
KMail/1.13.2 (Linux/2.6.31-21-generic; KDE/4.4.2; i686; ; ) |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am Dienstag, 4. Mai 2010 10:51:05 schrieb David Kastrup:
> Contained patch sets can be reasonably well exchanged by mail/mailing
> list.
My experience with this is that patches sent by mail will be forgotten the
next day. So, either you are lucky to get a response on the first day, or you
will never... I definitely prefer a reviewboard like rietvield (in KDE Pim we
also have our own reviewboard, which works a bit differently, but just as
well).
I have not eperienced the problems you are complaining about. In particular,
my patch for AJAX search in the docs was created 13 months ago, and recently
rebased/updated to current master. (http://codereview.appspot.com/24076/ )
Of course, updating the patch to current master took some time, because the
whole documentation file tree was completely overhauled. But you'll have that
problem in all cases, no matter whether you use rietvield, repo.or.cz or
patches sent via mail...
Plus, a simple "git-cl upload origin/master" after the rebase is just soo
much easier than generating patch files and attaching them to mails.
Cheers,
Reinhold
- --
- ------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
* Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
* Edition Kainhofer Music Publishing, http://www.edition-kainhofer.com/
* LilyPond music typesetting software, http://www.lilypond.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkvf8rAACgkQTqjEwhXvPN270wCfTAM8BpN640HSWftXpHtD8wbJ
LToAn1u2fXQKuZBGRMqO9MyF8UFjhQvA
=W7BR
-----END PGP SIGNATURE-----
- Re: markup-command and markup-command-list signatures, Boris Shingarov, 2010/05/02
- Re: markup-command and markup-command-list signatures, David Kastrup, 2010/05/03
- Rietveld review (was: markup-command and markup-command-list signatures), Carl Sorensen, 2010/05/03
- Re: Rietveld review, David Kastrup, 2010/05/04
- Re: Rietveld review, Werner LEMBERG, 2010/05/04
- Re: Rietveld review, David Kastrup, 2010/05/04
- Re: Rietveld review, Reinhold Kainhofer, 2010/05/04
- Re: Rietveld review, David Kastrup, 2010/05/04
- Re: Rietveld review,
Reinhold Kainhofer <=
- Re: Rietveld review, David Kastrup, 2010/05/04
- Re: Rietveld review, Carl Sorensen, 2010/05/04
- Re: Rietveld review, David Kastrup, 2010/05/04
- Re: Rietveld review, Carl Sorensen, 2010/05/06
- Re: Rietveld review, Christian Hitz, 2010/05/06
- Re: Rietveld review, Carl Sorensen, 2010/05/04
- Re: Rietveld review, David Kastrup, 2010/05/04
Re: markup-command and markup-command-list signatures, Carl Sorensen, 2010/05/03