[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch] Fix #1365: convert-ly shouldn't remove Dynamics performergro

From: Graham Percival
Subject: Re: [Patch] Fix #1365: convert-ly shouldn't remove Dynamics performergroup
Date: Sun, 7 Nov 2010 12:50:20 +0000
User-agent: Mutt/1.5.20 (2009-06-14)

On Sun, Nov 07, 2010 at 12:26:59PM -0000, Trevor Daniels wrote:
> Valentin Villenave wrote Sunday, November 07, 2010 10:35 AM
> >I'm not sure if we've ever used convert-ly to insert comments in
> >.ly
> >files, but I do think we should in this specific case: the
> >piano-centered dynamics template has been used by a *lot* of
> >people in
> >the past, and it's much more safe IMO if convert-ly puts a comment
> >as
> >some kind of a placeholder.
> Well, I never did master regular expressions, so I can't vouch for
> the
> accuracy of this, but I agree with inserting a comment when these
> lines
> are removed.

The normal method would be for convert-ly to print a warning
message to the console.  Why is this Dynamics thing so different
from previous changes?

- Graham

reply via email to

[Prev in Thread] Current Thread [Next in Thread]