|
From: | Carl . D . Sorensen |
Subject: | Re: vert. spacing: Rename properties (lily, scm). (issue3031041) |
Date: | Sat, 13 Nov 2010 01:09:24 +0000 |
On 2010/11/13 00:50:51, Mark Polesky wrote:
So, could it possibly be? Is this okay to push?
I like it a lot! Just one more thing -- James has captured new default values from Keith Ohara's work. Perhaps these new default values should be added as part of this patch. <http://codereview.appspot.com/3061041> Or maybe it could be a separate patch to push immediately after. But this change will invalidate James's patch, so we ought to at least be sure to handle that properly. Thanks, Carl http://codereview.appspot.com/3031041/
[Prev in Thread] | Current Thread | [Next in Thread] |