[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: mensural notation improvements (issue3797046)

From: Benkő Pál
Subject: Re: mensural notation improvements (issue3797046)
Date: Mon, 24 Jan 2011 12:39:00 +0100

hi Carl, thanks for reviewing!

> Let me start by saying I know *nothing* about mensural notation.
> The code looks good to me.
> I found only one real issue:
> LilyPond coding standards for C++ say that if there is only one
> statement in an if clause, we omit {} around that clause.

that's a pity - I hate adding/removing braces when the number of
statement changes.  nevertheless I'll change these instances.

> I also had a question (and it probably doesn't matter much).  When I've
> written font glyphs that are sometimes solid and sometimes hollow, I
> always calculate both the inner and outer paths.  And then when I create
> the glyph I only use the paths that are actually needed.  In your code,
> you didn't create the path unless it was needed.  It probably makes no
> difference at all, but I'd like to hear from the font gurus if there is
> a preference.
> My take was we only make the fonts at install, so the code doesn't need
> to be optimized for speed, so I optimized for readability, which in my
> mind, meant not putting the inner path inside a conditional.

in this case the shape of the inner path is conditional as well
(and it's truly nasty, I admit).

I'll upload a modified patchset tonight.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]