Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

[pnorcks]

Hi Mike,

I have a quick comment for you below.

Thanks,
Patrick


http://codereview.appspot.com/4213042/diff/24035/scm/define-stencil-commands.scm
File scm/define-stencil-commands.scm (right):

http://codereview.appspot.com/4213042/diff/24035/scm/define-stencil-commands.scm#newcode37
scm/define-stencil-commands.scm:37: footnote
Shouldn't this be in `ly:all-output-backend-commands' instead?

(Note the docstring for `ly:all-stencil-commands' versus the one for
`ly:all-output-backend-commands'.)

Some extra processing is done for elements of this list (see
scm/backend-library.scm).  If the stencil expression is not defined in
the backends, then it should be in the ly:all-output-backend-commands
list instead to avoid unnecessary (though minimal) overhead.

http://codereview.appspot.com/4213042/