[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ambitus: special handling of small ambits' lines (issue4609041)

From: mtsolo
Subject: Re: ambitus: special handling of small ambits' lines (issue4609041)
Date: Fri, 17 Jun 2011 07:18:49 +0000

Good work!  A few comments below.
File scm/define-grobs.scm (right):
scm/define-grobs.scm:141: (woot . 1)
This seems like 1337 $p34k - I have never heard woot in any other
context.  Perhaps change to something more descriptive?
File scm/output-lib.scm (right):
scm/output-lib.scm:944: (linear-gap (+ (max gap-property 0.3) -0.45
Indentation: the -0.45 should be on the next line & lined up with the
left-parenthesis of (max.
scm/output-lib.scm:950: (unwooted (max (min calculated-gap gap-property)
(/ gap-property 4.5)))
80 column max
scm/output-lib.scm:951: (gap (+ (* unwooted woot) (* gap-property (- 1
This codes a lot of properties.  I'm fine with the code (though I'd need
to see a regtest).  Can you try using a "details" property (like for the
Beam grob) that stores all of these values?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]