[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055)
From: |
n . puttock |
Subject: |
Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055) |
Date: |
Sun, 03 Jul 2011 21:25:58 +0000 |
Hi Carl,
This LGTM, though the regtest could do with a bit of tidying.
A more correct approach would be to filter interfaces since the
Ligature_engraver also potentially acknowledges PitchTrillGroup. It's
probably not worth the bother though: it does have an event-cause and is
ignored by the ligature engravers; furthermore, it's unlikely
\pitchedTrill would be used in conjunction with such ligatures.
Cheers,
Neil
http://codereview.appspot.com/4667055/diff/2001/lily/ligature-engraver.cc
File lily/ligature-engraver.cc (right):
http://codereview.appspot.com/4667055/diff/2001/lily/ligature-engraver.cc#newcode199
lily/ligature-engraver.cc:199: if (info.event_cause ()) // Ignore
AmbitusNoteHead which has no event_cause
if (info.event_cause ()
&& ligature_)
http://codereview.appspot.com/4667055/
- Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), Carl . D . Sorensen, 2011/07/03
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055),
n . puttock <=
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), Carl . D . Sorensen, 2011/07/03
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), n . puttock, 2011/07/03
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), n . puttock, 2011/07/03
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), pkx166h, 2011/07/03
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), Carl . D . Sorensen, 2011/07/03
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), n . puttock, 2011/07/04
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), Carl . D . Sorensen, 2011/07/04
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), Carl . D . Sorensen, 2011/07/04
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), n . puttock, 2011/07/05