[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055)
From: |
Carl . D . Sorensen |
Subject: |
Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055) |
Date: |
Mon, 04 Jul 2011 01:54:40 +0000 |
Instead of filtering out bad events, I chose to filter in only events
with ligature interfaces.
I'm not sure my line-breaking is correct on the internal_has_interface
() calls, but we'll soon have fixcc.py working, right? :) If it isn't
right, please help me know how to fix it.
I also trimmed the regtest.
Thanks,
Carl
http://codereview.appspot.com/4667055/diff/2001/lily/ligature-engraver.cc
File lily/ligature-engraver.cc (right):
http://codereview.appspot.com/4667055/diff/2001/lily/ligature-engraver.cc#newcode199
lily/ligature-engraver.cc:199: if (info.event_cause ()) // Ignore
AmbitusNoteHead which has no event_cause
On 2011/07/03 21:25:58, Neil Puttock wrote:
if (info.event_cause ()
&& ligature_)
Done.
http://codereview.appspot.com/4667055/
- Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), Carl . D . Sorensen, 2011/07/03
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), n . puttock, 2011/07/03
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), Carl . D . Sorensen, 2011/07/03
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), n . puttock, 2011/07/03
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), n . puttock, 2011/07/03
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), pkx166h, 2011/07/03
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055),
Carl . D . Sorensen <=
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), n . puttock, 2011/07/04
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), Carl . D . Sorensen, 2011/07/04
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), Carl . D . Sorensen, 2011/07/04
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), n . puttock, 2011/07/05
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), Carl . D . Sorensen, 2011/07/06
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), n . puttock, 2011/07/07
- Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055), Carl . D . Sorensen, 2011/07/07