Re: Creates a Flag grob. (issue 4922042)

[Mike Solomon]

On Aug 22, 2011, at 12:06 PM, address@hidden wrote:

http://codereview.appspot.com/4922042/diff/1/input/regression/color.ly
File input/regression/color.ly (right):

http://codereview.appspot.com/4922042/diff/1/input/regression/color.ly#newcode24
input/regression/color.ly:24: \override Flag #'color = #blue
Why don't you choose a different color to check that the two grobs are
really handled differently?

Done.

http://codereview.appspot.com/4922042/diff/1/lily/flag.cc
File lily/flag.cc (right):

http://codereview.appspot.com/4922042/diff/1/lily/flag.cc#newcode54
lily/flag.cc:54: '() or "grace").  */
That comment should be moved down to stroke-style

Done.

http://codereview.appspot.com/4922042/diff/1/lily/flag.cc#newcode97
lily/flag.cc:97: if (scm_is_string (stroke_style_scm))
Sooner or later, that should be moved out from here into its own grob.
Then we can also have slashed beamed grace notes (which don't have any
flag).

Agreed.

http://codereview.appspot.com/4922042/diff/1/lily/tie-formatting-problem.cc
File lily/tie-formatting-problem.cc (right):

http://codereview.appspot.com/4922042/diff/1/lily/tie-formatting-problem.cc#newcode177
lily/tie-formatting-problem.cc:177: boxes.push_back (Box (flag->extent
(x_refpoint_, X_AXIS), flag->extent (commony, Y_AXIS)));
Line too long

Fixed.

http://codereview.appspot.com/4922042/diff/1/ly/engraver-init.ly#newcode787
ly/engraver-init.ly:787: \override Flag #'flag-style = #'no-flag
Do we need/want a convert-ly warning for \override Stem #'flag-style?

Yes - I'd put this in a separate patch/issue (unless people think it belongs here - it seems that convert-ly rules usually come after patches get pushed).

http://codereview.appspot.com/4922042/diff/1/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

http://codereview.appspot.com/4922042/diff/1/scm/define-grob-properties.scm#newcode276
scm/define-grob-properties.scm:276: (flag-style ,symbol? "A symbol
determining what style of flag
rename to style? Unfortunately, then we don't have any documentation any
more about the valid values... :(

You've hit the proverbial nail on its proverbial head.  It is for this reason that I'm wary about renaming.

New patchset up, and thanks for your comments!

Cheers,

MS