[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Creates a Flag grob. (issue 4922042)
|
From: |
Han-Wen Nienhuys |
|
Subject: |
Re: Creates a Flag grob. (issue 4922042) |
|
Date: |
Mon, 22 Aug 2011 09:52:03 -0300 |
On Mon, Aug 22, 2011 at 7:20 AM, Mike Solomon <address@hidden> wrote:
> http://codereview.appspot.com/4922042/diff/1/scm/define-grob-properties.scm#newcode276
> scm/define-grob-properties.scm:276: (flag-style ,symbol? "A symbol
> determining what style of flag
> rename to style? Unfortunately, then we don't have any documentation any
> more about the valid values... :(
>
> You've hit the proverbial nail on its proverbial head. It is for this
> reason that I'm wary about renaming.
Yes, but please rename anyway. You could put the 'style values in the
doc of flag-interface.
--
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen
Re: Creates a Flag grob. (issue 4922042), mtsolo, 2011/08/27