Issue 4154: Compact Chord Symbols Patch (issue 153160043 by address@hidden)

[dak]

Reviewers: ,


https://codereview.appspot.com/153160043/diff/1/scm/chord-ignatzek-names.scm
File scm/chord-ignatzek-names.scm (right):

https://codereview.appspot.com/153160043/diff/1/scm/chord-ignatzek-names.scm#newcode98
scm/chord-ignatzek-names.scm:98: (vector-ref #("C" "D" "E" "F" "G" "A"
"B") (ly:pitch-notename
This looks like a bad idea.  It does not obey the various chord name
languages.  It does not use the same callbacks.  It is a large
duplication of code not connected with the other code and not using the
same options, functionality and interfaces.

Can't you try to integrate this kind of code better with the existing
code, both regarding the code that is called as well as the naming
conventions and functionality that are available?

Description:
Issue 4154: Compact Chord Symbols Patch

Please review this at https://codereview.appspot.com/153160043/

Affected files (+100, -26 lines):
  M scm/chord-ignatzek-names.scm
  M scm/define-context-properties.scm