|
| From: | thomasmorley65 |
| Subject: | Re: Let \addlyrics accept an optional context mod (issue 255610043 by address@hidden) |
| Date: | Mon, 03 Aug 2015 10:24:32 +0000 |
Can't review parser-code.
Otherwise:
Doing \layout { \context { \Lyrics ... } } will work for the Lyrics
created by \addlyrics as well. Thus it's more than consistent to allow
\with { ... } for \addlyrics. I'd say it was a badly missing feature.
My point: Looks very good to me!
About Documentation:
Put it in:
"
NR 5.1.5 Changing context default settings
Changing just one specific context
"
Wherelse?
Maybe as an exception from:
" The \with block must be placed immediately after the \new context-type
command"
Offtopic:
https://codereview.appspot.com/255610043/diff/10003/scm/ly-syntax-constructors.scm
File scm/ly-syntax-constructors.scm (right):
https://codereview.appspot.com/255610043/diff/10003/scm/ly-syntax-constructors.scm#newcode53
scm/ly-syntax-constructors.scm:53: (if (ly:music? (cdr sigcar))
Not related to this patch:
I stumbled across this two days ago with 2.19.24. and found out James
and you already noticed.
Obviously you fixed it. Is there an issue on the tracker for it?
https://codereview.appspot.com/255610043/
| [Prev in Thread] | Current Thread | [Next in Thread] |