Re: Set the sequence name in MIDI using title information from \header block (issue 256230045 by address@hidden)

[lemzwerg]

I don't have enough knowledge for a LGTM, but reading the source code I
noticed one detail...


https://codereview.appspot.com/256230045/diff/1/lily/performance.cc
File lily/performance.cc (right):

https://codereview.appspot.com/256230045/diff/1/lily/performance.cc#newcode92
lily/performance.cc:92: text->text_string_ = name;
This code allows overwriting `control track' only once.  I guess this is
intended, however, it looks limiting.  Wouldn't it be better to identify
the control track by another property, say
Audio_text::CONTROL_TRACK_NAME, instead of a comparison with a string
that the user might modify?

https://codereview.appspot.com/256230045/