lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Set the sequence name in MIDI using title information from \header b


From: ht . lilypond . development
Subject: Re: Set the sequence name in MIDI using title information from \header block (issue 256230045 by address@hidden)
Date: Thu, 06 Aug 2015 11:57:01 +0000


https://codereview.appspot.com/256230045/diff/1/lily/performance.cc
File lily/performance.cc (right):

https://codereview.appspot.com/256230045/diff/1/lily/performance.cc#newcode41
lily/performance.cc:41: header_ (SCM_EOL)
On 2015/08/06 11:22:27, dak wrote:
On 2015/08/06 11:05:56, ht wrote:
> I added the Performance::mark_smob member function
> that should handle the new SCM member variable.

That's wrong.  mark_smob is not a virtual member function of
Music_output so
there is no reason Performance::mark_smob will ever be called.

Ok, so I overlooked the significance of Music_output and used an
incorrect smob class (Score) as a model for extending Performance when
I'd been better off with using (for example) Paper_book instead.  Thanks
for the correction, I hope to have got it right this time.

https://codereview.appspot.com/256230045/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]