Re: Issue 4564: make Grob an abstract class (issue 260810043 by address@hidden)

[hanwenn]

On 2015/08/26 11:22:18, dak wrote:
> On 2015/08/26 11:17:23, hanwenn wrote:
> > not LGTM
> >
> > I'll follow up on the bug.

> Well, if anybody could it would be you, working at Google.  But I
guess for now
> you'll have to explain on the Rietveld review.  Google Code has been
switched to
> readonly.

"preparation of .. " : deriving from Grob is not a feature but a risk.
In fact,  it would even be nice if Item and Spanner could disappear, but
that seems to be intractable.

I spent a giant amount of energy distangling formatting logic from C++
type hierarchy, so behaviors can be mixed and matched at runtime, and
this is taking a step in the opposite direction.


https://codereview.appspot.com/260810043/