Re: [lmi] help with orphan-control in xsl-fo

[Greg Chicares]

On 2009-05-17 09:41Z, Vaclav Slavik wrote:
> [...] Please apply this patch to fix it:

I'm following this patch, and the others you've proposed, with
great interest. Lest anyone suppose otherwise, let me explain the
practical reasons why I'm not yet applying them (or any of my own)
to lmi HEAD this weekend.

All fo changes need careful testing. And that testing is manual,
because we've found no readily-practicable way of automating it.
That'll take time.

In some cases, our intention isn't necessarily clear:
  http://lists.nongnu.org/archive/html/lmi/2009-05/msg00024.html
| Alternatively, if this header shouldn't span over the extra column
| [...] Or, if the number
| of columns is always a fixed number for this template [...]
and we may need to choose an alternative.

Some changes won't work with both fop-0.20.5 and fop-0.95: for
instance, the patch below breaks 0.20.5 [*], but is required for
0.95 . It might be possible to write conditional xslt code that
depends on the fop version, but that doesn't seem wise. I think
we'll want to set up all the changes off to the side, and then
commit them together when we decide to upgrade fop.

---------

[*] "the patch below breaks 0.20.5"

Index: fo_common.xsl
===================================================================
RCS file: /sources/lmi/lmi/fo_common.xsl,v
retrieving revision 1.69
diff -U 3 -r1.69 fo_common.xsl
--- fo_common.xsl       6 May 2009 14:52:11 -0000       1.69
+++ fo_common.xsl       17 May 2009 15:00:53 -0000
@@ -748,7 +748,7 @@

   <xsl:template name="company-logo">
     <xsl:if test="not($hide-company-logo)">
-      <fo:external-graphic width="121.1pt" height="24.8pt" 
src="company_logo.png"/>
+      <fo:external-graphic content-height="9mm" src="company_logo.png"/>
     </xsl:if>
   </xsl:template>