[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Monotone-devel] mainline unit tests fixed

From: Markus Schiltknecht
Subject: [Monotone-devel] mainline unit tests fixed
Date: Tue, 25 Mar 2008 21:48:25 +0100
User-agent: Mozilla-Thunderbird (X11/20080109)


I've hopefully fixed the two tests, which were failing on mainline. The first, non_workspace_keydir, one was failing, because it expected no keys in the keydir. If you had some in $HOME/keys, it failed. I've solved this by creating an empty directory and setting $HOME to that. I'm not sure what to expect on Windows. Somebody with access to a windozen box please check.

The second one took me more than an hour, because my knowledge of the ssh_agent is pretty uhm.. non-existent. Anyway, it turned out, that removing "--ssh-sign=no" from safe_mtn() in lua-testsuite.lua did the trick.

It looks like Stephen added that in revision d7b34554... I cannot see any reason for that addition, so I've removed it again. Stephen, please, before you commit, run the testsuite - that's what we have it for. Then commit on mainline only if it passes all the tests. Use a branch if you want to commit experimental stuff, which doesn't pass the tests.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]