[pdf-devel] Public API and gl_list

[gerel]

Well, the way I solved the issue is adding "/* BEGIN PUBLIC */" and "/* END
PUBLIC */" on the gl_list and gl_array_list files and then adding them to
PUBLIC_HDRS in src/Makefile.am.

If you think it's not a good idea to modify those headers we should copy them
to another location and modify them there. I guess it's the same.

OTOH, I'm not totally sure about the inclusions of "stddef.h" and "stdbool.h"
which are needed by gl_list and whose include directives are in "pdf-types.h".
They may not be portable across platforms and they're small enough that we
could create our own versions.

Here are the corresponding patches.

##

Index: lib/gl_array_list.h
===================================================================
RCS file: /sources/pdf/libgnupdf/lib/gl_array_list.h,v
retrieving revision 1.1
diff -u -r1.1 gl_array_list.h
--- lib/gl_array_list.h 7 Jul 2007 12:53:08 -0000       1.1
+++ lib/gl_array_list.h 9 Mar 2008 00:48:02 -0000
@@ -21,6 +21,8 @@
 
 #include "gl_list.h"
 
+/* BEGIN PUBLIC */
+
 #ifdef __cplusplus
 extern "C" {
 #endif
@@ -32,4 +34,6 @@
 }
 #endif
 
+/* END PUBLIC */
+
 #endif /* _GL_ARRAY_LIST_H */


Index: lib/gl_list.h
===================================================================
RCS file: /sources/pdf/libgnupdf/lib/gl_list.h,v
retrieving revision 1.1
diff -u -r1.1 gl_list.h
--- lib/gl_list.h       7 Jul 2007 01:02:03 -0000       1.1
+++ lib/gl_list.h       9 Mar 2008 00:48:03 -0000
@@ -22,6 +22,8 @@
 #include <stdbool.h>
 #include <stddef.h>
 
+/* BEGIN PUBLIC */
+
 #ifdef __cplusplus
 extern "C" {
 #endif
@@ -443,6 +445,10 @@
   bool allow_duplicates;
 };
 
+
+/* END PUBLIC */
+
+
 #if HAVE_INLINE
 
 /* Define all functions of this file as inline accesses to the
@@ -730,8 +736,13 @@
 
 #endif
 
+
+/* BEGIN PUBLIC */
+
 #ifdef __cplusplus
 }
 #endif
 
+/* END PUBLIC */
+
 #endif /* _GL_LIST_H */


Index: src/Makefile.am
===================================================================
RCS file: /sources/pdf/libgnupdf/src/Makefile.am,v
retrieving revision 1.38
diff -u -r1.38 Makefile.am
--- src/Makefile.am     7 Mar 2008 13:58:37 -0000       1.38
+++ src/Makefile.am     9 Mar 2008 00:48:03 -0000
@@ -78,6 +78,8 @@
               base/pdf-types.h \
               base/pdf-error.h \
               base/pdf-alloc.h \
+              $(top_srcdir)/lib/gl_list.h \
+              $(top_srcdir)/lib/gl_array_list.h \
               base/pdf-list.h \
               base/pdf-stm-f-a85.h \
               base/pdf-stm-f-ahex.h \


Index: src/base/pdf-types.h
===================================================================
RCS file: /sources/pdf/libgnupdf/src/base/pdf-types.h,v
retrieving revision 1.5
diff -u -r1.5 pdf-types.h
--- src/base/pdf-types.h        7 Mar 2008 13:58:37 -0000       1.5
+++ src/base/pdf-types.h        9 Mar 2008 00:48:03 -0000
@@ -1,4 +1,4 @@
-/* -*- mode: C -*- Time-stamp: "2008-03-06 00:07:40 gerel"
+/* -*- mode: C -*- Time-stamp: "2008-03-08 21:21:47 gerel"
  *
  *       File:         pdf-types.h
  *       Date:         Sun Feb 10 21:30:00 2008
@@ -29,6 +29,8 @@
 #include <config.h>
 /* BEGIN PUBLIC */
 #include <sys/types.h> /* for off_t */
+#include <stdbool.h> /* gl_list */
+#include <stddef.h> /* gl_list */
 /* END PUBLIC */
 
 #ifdef HAVE_INLINE


Index: src/base/pdf-list.h
===================================================================
RCS file: /sources/pdf/libgnupdf/src/base/pdf-list.h,v
retrieving revision 1.1
diff -u -r1.1 pdf-list.h
--- src/base/pdf-list.h 7 Mar 2008 13:58:37 -0000       1.1
+++ src/base/pdf-list.h 9 Mar 2008 00:48:03 -0000
@@ -1,4 +1,4 @@
-/* -*- mode: C -*- Time-stamp: "2008-03-06 21:35:03 gerel"
+/* -*- mode: C -*- Time-stamp: "2008-03-08 21:10:45 gerel"
  *
  *       File:         pdf-list.h
  *       Date:         Sat Mar 1 02:14:35 2008
@@ -28,12 +28,10 @@
 
 #include <pdf-types.h>
 #include <pdf-error.h>
-
+#include <gl_array_list.h>
 
 /* BEGIN PUBLIC */
 
-#include <gl_array_list.h>
-
 /* List module API implementation */
 
 /* Data types */

###


cheers

-gerel