pdf-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [pdf-devel] Public API and gl_list


From: jemarch
Subject: Re: [pdf-devel] Public API and gl_list
Date: Mon, 10 Mar 2008 18:46:25 +0100
User-agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (Shijō) APEL/10.6 Emacs/23.0.60 (x86_64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)

   struct pdf_list_s
   {
     void *gl_list;
   };

   struct pdf_list_iterator_s
   {
     void *gl_iterator;
   };

   struct pdf_list_node_s
   {
     void *gl_node;
   };


   typedef pdf_list_s *pdf_list_t;
   typedef pdf_list_node_s *pdf_list_node_t;
   typedef pdf_list_iterator_s *pdf_list_iterator_t;

Fine for me.

   Another issue is the function pointers,

   typedef bool (*gl_listelement_equals_fn) (const void *elt1, const void 
*elt2);
   typedef size_t (*gl_listelement_hashcode_fn) (const void *elt);
   typedef void (*gl_listelement_dispose_fn) (const void *elt);

   I think they're just fine for inclusion in pdf-list.h, don't you ?

Yes. But it is much better to change the names of the callback types
to pdf_list_element_equals_fn, pdf_list_element_hashcode_fn and
pdf_list_element_dispose_fn.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]