pdf-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [pdf-devel] Public API and gl_list


From: jemarch
Subject: Re: [pdf-devel] Public API and gl_list
Date: Tue, 11 Mar 2008 20:01:24 +0100
User-agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (Shijō) APEL/10.6 Emacs/23.0.60 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)

    > Is that `pdf_dealloc' on iterator->gl_iterator ok? I think that the
    > previous `gl_list_iterator_free' call is disposing the memory pointed
    > by iterator->gl_iterator.
    > 

   Well, gl_list_iterator() returns a structure and structures are assignable,
   so it may be that gl_list_free() frees gl_list_iterator_t _members_ but not 
the
   actual structure. If it does in a future update then gl_list_iterator() 
should
   return a pointer if any coherence is to be kept.

Yes. It makes sense. We allocated that pointer and we should free it
:)

Did you pass your little test case to the new implementation? If yes,
please commit it to CVS. 

Do not forget to write a ChangeLog entry and to update the AUTHORS
file if appropriate.

Thanks.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]