Re: [pdf-devel] Public API and gl_list

[gerel]

 > Date: Mon, 10 Mar 2008 20:41:22 +0100
 > From: address@hidden
 > 
 > 
 >     >  >    Another issue is the function pointers,
 >     >  > 
 >     >  >    typedef bool (*gl_listelement_equals_fn) (const void *elt1, 
 > const void *elt2);
 >     >  >    typedef size_t (*gl_listelement_hashcode_fn) (const void *elt);
 >     >  >    typedef void (*gl_listelement_dispose_fn) (const void *elt);
 >     >  > 
 >     >  >    I think they're just fine for inclusion in pdf-list.h, don't you 
 > ?
 >     >  > 
 >     >  > Yes. But it is much better to change the names of the callback types
 >     >  > to pdf_list_element_equals_fn, pdf_list_element_hashcode_fn and
 >     >  > pdf_list_element_dispose_fn.
 >     >  > 
 >     > 
 >     > Of course.
 > 
 >    BTW, I'm thinking in declaring pdf_list_t, etc, to be a structure and not 
 > a
 >    pointer to one, otherwise we'll need to change the list API. 
 > 
 > Why? 
 > 
 >    I prefer the structure based version. 
 >    What do you think ?
 > 
 > I don't have objections to use structures rather than pointer to
 > structures in this case.
 > 
 > 

Ah, ok it doesn't matter. Going with pointers anyway.

-gerel